D6079: tests: simplify test-uncommit.t by removing an unnecessary commit

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Thu Mar 7 11:41:38 EST 2019


martinvonz added inline comments.

INLINE COMMENTS

> pulkit wrote in test-uncommit.t:483
> I skimmed through the whole file and could not find a case where we do `hg uncommit PATH` on a dirty wdir and PATH is not dirty in wdir. So I think it's better to have this test.

Ohh, I didn't even realize that was allowed! :) And I obviously agree with testing that in that case.  Could we have a separate test description for that then (so it's not just part of "--allow-dirty-working-copy should also work on a dirty PATH")?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6079

To: martinvonz, #hg-reviewers
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list