D6005: uncommit: added interactive mode -i(issue6062)

taapas1128 (Taapas Agrawal) phabricator at mercurial-scm.org
Thu Mar 7 16:02:09 EST 2019


taapas1128 marked 3 inline comments as done.
taapas1128 added inline comments.

INLINE COMMENTS

> martinvonz wrote in uncommit.py:109-110
> I don't follow the "not containing changed files matched by match" part. It *only* fixes the parts matched by the matches, right? Also, I think the matcher is just an optimization -- it would be incorrect, I think, to pass a matcher that doesn't match all the changes between oldctx and newctx. I'd just leave the comment untouched for now. We may even want to remove the matcher argument, but we can do that in a separate patch, if at all.

It is the  part of _uncommitdirstate() that has been left behind. okay I am not changing that

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6005

To: taapas1128, #hg-reviewers
Cc: pulkit, martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list