D6005: uncommit: added interactive mode -i(issue6062)

taapas1128 (Taapas Agrawal) phabricator at mercurial-scm.org
Fri Mar 8 12:39:47 EST 2019


taapas1128 added inline comments.

INLINE COMMENTS

> martinvonz wrote in uncommit.py:399
> Instead of defining a value here, specify the argument by name when you call the function: `_uncommitdirstate(..., interactive=False)`. But it's probably better to just make `interactive` default to `False` and not pass it here.

@martinvonz this part of the patch too (`323,329,366`) has no relation with interactive uncommit but it makes `match` optional for `unamend`. Should I remove is and send it as a seperate patch too ?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6005

To: taapas1128, #hg-reviewers
Cc: pulkit, martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list