D6005: uncommit: added interactive mode -i(issue6062)

Fri Mar 8 12:41:22 EST 2019

martinvonz added inline comments.

INLINE COMMENTS

> taapas1128 wrote in uncommit.py:399
> @martinvonz this part of the patch too (`323,329,366`) has no relation with interactive uncommit but it makes `match` optional for `unamend`. Should I remove is and send it as a seperate patch too ?

Yes, please do. Then we can consider while reviewing that patch if we even need to pass the matcher. It's better to have that discussion separate from this patch.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6005

To: taapas1128, #hg-reviewers
Cc: pulkit, martinvonz, mercurial-devel