D6005: uncommit: added interactive mode -i(issue6062)
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Fri Mar 8 12:41:22 EST 2019
martinvonz added inline comments.
> taapas1128 wrote in uncommit.py:399
> @martinvonz this part of the patch too (`323,329,366`) has no relation with interactive uncommit but it makes `match` optional for `unamend`. Should I remove is and send it as a seperate patch too ?
Yes, please do. Then we can consider while reviewing that patch if we even need to pass the matcher. It's better to have that discussion separate from this patch.
To: taapas1128, #hg-reviewers
Cc: pulkit, martinvonz, mercurial-devel
More information about the Mercurial-devel