D6082: phabricator: add a `--branch` flag to `hg phabsend`
mharbison72 (Matt Harbison)
phabricator at mercurial-scm.org
Sat Mar 9 13:27:00 EST 2019
mharbison72 added a comment.
In https://phab.mercurial-scm.org/D6082#88981, @Kwan wrote:
> In https://phab.mercurial-scm.org/D6082#88852, @mharbison72 wrote:
> > In https://phab.mercurial-scm.org/D6082#88851, @pulkit wrote:
> > > @mharbison72 thanks for tips on adding test. Will add tests in next iteration.
> > >
> > > I found that Differentials do have a branch field, maybe we can use that? https://secure.phabricator.com/source/phabricator/browse/master/src/applications/differential/customfield/DifferentialBranchField.php
> > Seems worth a shot. I don’t know anything about it, but presumably this would be rendered specially in the web UI, like the test plan, etc. That sounds better than as a follow up comment. It also seems natural enough that maybe it can be done unconditionally, instead of needing the argument.
> Yeah, it shows in the Diff Detail pane, like here <https://phabricator-dev.allizom.org/D1092?id=1765>. Unfortunately I think it can be only set when using the creatediff endpoint, which is what I had to change my fork to do (though I could be wrong, the conduit docs are too sparse to be sure).
Yeah, that's kinda how I read the documentation too :/
I wonder if we can use `parents.set` in `differential.revision.edit` on the first commit in the series. Or add the branch name to the existing metadata wiith `differential.setdiffproperty`? I've aliased `phabimport` to `!"%HG%" phabread $1 --stack | "%HG%" import --bypass -`, but maybe a first class phabimport that knows how to use the data would make the tooling easier?
To: pulkit, #hg-reviewers
Cc: Kwan, mharbison72, mercurial-devel
More information about the Mercurial-devel