D6103: py3: use pycompat.iterbytestr to convert itertools.takewhile result back to bytes

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Sat Mar 9 20:29:51 EST 2019


yuja added a comment.


  Queued most of the patches in this series, thanks.
  
  > - symbol = b''.join(itertools.takewhile(lambda ch: ch not in special,
  > - view[pos:])) +        symbol = b''.join(pycompat.iterbytestr(itertools.takewhile( +            lambda ch: ch not in special, +            view[pos:]
  
  It's probably better to apply `iterbytestr()` to `view[pos:]` so `ch` is
  always a byte string.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6103

To: Kwan, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list