D5963: copies: handle a case when both merging csets are not descendant of merge base

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Sun Mar 10 13:10:32 EDT 2019


martinvonz added a comment.


  In https://phab.mercurial-scm.org/D5963#88980, @khanchi97 wrote:
  
  > Gentle ping for review.
  
  
  FYI, I finally have some time to review this. I recently wrote a changeset-centric version of pathcopies(). I was going to do the same with mergecopies(), but I had not gotten around to it yet, so I'm not very familiar with that code yet. I spent around two hours trying to understand the code yesterday. I'll spend some more tonight. Hopefully I'll be able to say if I agree with the patch after that :)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5963

To: khanchi97, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list