D6115: unamend: made match optional in firdirstate()

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Mon Mar 11 12:14:01 EDT 2019

martinvonz added a comment.

  > unamend: made match optional in firdirstate()
  Typo'd "_fixdirstate"
  Also, the matcher has been optional since https://phab.mercurial-scm.org/D5661, so the description seems wrong. The commit message should also explain the reason for the patch, unless that's obvious (things like "remove unused argument 'foo' for bar()" don't need a motivation, IMO).

  rHG Mercurial


To: taapas1128, #hg-reviewers
Cc: martinvonz, mercurial-devel

More information about the Mercurial-devel mailing list