D6038: push: added clear warning message when pushing a closed branch(issue6080)

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Mon Mar 11 12:28:22 EDT 2019


mharbison72 added inline comments.

INLINE COMMENTS

> discovery.py:358
> +            errmsg = (_("push creates new remote branches: %s (closed)!")
> +                        % branchnames)
> +        else:

I had assumed from the bug report that the request was to annotate each closed branch as closed, so I interpreted the output incorrectly.  It might be too much output to put `(closed)` after each closed branch in the list if it is long.  But maybe `"(%d closed)" % len(closedbranches)` will make it less ambiguous?  See what others think.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6038

To: taapas1128, #hg-reviewers
Cc: pulkit, mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list