D6038: push: added clear warning message when pushing a closed branch(issue6080)

taapas1128 (Taapas Agrawal) phabricator at mercurial-scm.org
Mon Mar 11 12:38:22 EDT 2019

taapas1128 added inline comments.


> mharbison72 wrote in discovery.py:358
> I had assumed from the bug report that the request was to annotate each closed branch as closed, so I interpreted the output incorrectly.  It might be too much output to put `(closed)` after each closed branch in the list if it is long.  But maybe `"(%d closed)" % len(closedbranches)` will make it less ambiguous?  See what others think.

maybe we can just add (contains closed branches) at the end of the message.

  rHG Mercurial


To: taapas1128, #hg-reviewers
Cc: pulkit, mharbison72, mercurial-devel

More information about the Mercurial-devel mailing list