D6123: Experimental features: Add condition to for float number (issue6099)
av6 (Anton Shestakov)
phabricator at mercurial-scm.org
Wed Mar 13 05:20:27 EDT 2019
av6 added a comment.
I find it troubling that we now have contributors that don't follow #1 in https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist. Potentially #4 too (as Pulkit commented).
Seriously, the title is terrible at describing what this patch fixes and where. The commit message could briefly mention why/when this condition is even required.
> lengths = len(text) + len(orig)
> + if lengths > 0:
> return equal * 2.0 / lengths
This is some... interesting syntax. Is this valid Python?
To: akshjain.jain74, durin42, #hg-reviewers
Cc: av6, pulkit, mercurial-devel
More information about the Mercurial-devel