D6005: uncommit: added interactive mode -i(issue6062)
taapas1128 (Taapas Agrawal)
phabricator at mercurial-scm.org
Thu Mar 14 12:08:17 EDT 2019
taapas1128 added a comment.
@martinvonz I have made the necessary modifications and updated the description.
> martinvonz wrote in test-uncommit-interactive.t:110
> I think at least @spectral and @ryanmce had previously suggested that `hg revert -i` should ask you what pieces to keep, not what to discard. Your patch reminded me of that discussion, so I sent https://phab.mercurial-scm.org/D6125. I'm curious to hear what others think about `hg uncommit -i`. Should it ask you what to discard or what to keep? I can see arguments both ways.
> Perhaps the strongest argument in favor if showing what to keep is that it makes uncommitting part of a line *much* easier. Let's say you changed a line from "a" to "c" in the commit and you meant to change it to "b" in the commit and leave the change to "c" in the working copy. You'd be presented with this:
> If what you select is what to keep in the commit, then it seems pretty obvious that you should change that to:
> It's much less obvious what to do if you select what to discard.
> I think it would also make it easier to implement this feature if the user selected what to keep (we would create a commit based on that and then move the dirstate there).
Can I work on this as a part as a follow up ? or should i make amends in this patch .
To: taapas1128, #hg-reviewers
Cc: ryanmce, spectral, pulkit, martinvonz, mercurial-devel
More information about the Mercurial-devel