D6058: patch: include flag-only file changes in "special" while filtering patch (issue5864)

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Thu Mar 14 12:47:40 EDT 2019


mharbison72 requested changes to this revision.
mharbison72 added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> test-split.t:744
> +  > EOF
> +  !!! nested #if
> +#if obsstore-on

This happens because you can't have nested `#if`.  i.e. this doesn't work:

  #if ..
  ...
  #if ..
  ...
  #endif
  #endif

You can list multiple requirements on a line, and it is effectively `&&` IIRC.

I don't see any obvious differences in the output though, other that the bundle saving in the `obsstore-off` case.  I think what you can do here is conditionalize just that line by appending ` (obsstore-off !)` to it the way you would a `(!)`, `(glob)`, or whatever.  That means it must be there for `obsstore-off`.  Conditionalizing the output also makes it easier to see the differences between the difference cases in general.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6058

To: khanchi97, #hg-reviewers, mharbison72
Cc: mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list