D6038: push: added clear warning message when pushing a closed branch(issue6080)

[pulkit (Pulkit Goyal)]

pulkit added inline comments.

INLINE COMMENTS

> discovery.py:351
> +        if isclosed == True:
> +            closedbranches.append((tag))
> +

This is calculating all the closed branches in a repo. We need to find the closed branches which are in the newbranches list.

> mharbison72 wrote in discovery.py:358
> I had assumed from the bug report that the request was to annotate each closed branch as closed, so I interpreted the output incorrectly.  It might be too much output to put `(closed)` after each closed branch in the list if it is long.  But maybe `"(%d closed)" % len(closedbranches)` will make it less ambiguous?  See what others think.

> But maybe "(%d closed)" % len(closedbranches) will make it less ambiguous

This is a nice idea. Let's do it this way. What do you think?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6038

To: taapas1128, #hg-reviewers
Cc: pulkit, mharbison72, mercurial-devel