D6142: automation: perform tasks on remote machines

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Fri Mar 15 23:23:15 EDT 2019


mharbison72 added a comment.


  I don't know anything about PowerShell or AWS, but this series looks nice for making Windows easier to deal with.
  
  What was the problem with python3 tests?  I've been able to run them locally (though a bunch fail with py3 issues).
  
  I've been hacking on and off with running tests under WSL.  I'm not sure if that will help any of this.  It's tantalizingly close, but there are path style issues that `WSLENV` and `wslpath` can't fix.  (e.g., sometimes $TESTTMP is written to an hgrc file in Linux format, and hg.exe can't understand that.)
  
  Any plans to port this to the TortoiseHg codebase?  I don't have the bandwidth to try anything in the near term, but don't want to duplicate effort.

INLINE COMMENTS

> windows.py:97
> +RUN_TESTS = r'''
> +C:\hgdev\MinGW\msys\1.0\bin\sh.exe --login -c "cd /c/hgdev/src/tests && /c/hgdev/{python_path}/python.exe run-tests.py {test_flags}"
> +if ($LASTEXITCODE -ne 0) {{

There's an annoying issue with MSYS where it will convert the username part of %TEMP% and %TMP% to 8.3 format with a `~` if it is long-ish.  That throws a few tests into disarray.  Given how MSYS is bootstrapped here, I wonder if those variables can be set to `C:\hgdev\tmp` or similar first.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6142

To: indygreg, #hg-reviewers
Cc: mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list