D6005: uncommit: added interactive mode -i(issue6062)

taapas1128 (Taapas Agrawal) phabricator at mercurial-scm.org
Sat Mar 16 06:12:21 EDT 2019

taapas1128 added inline comments.


> martinvonz wrote in uncommit.py:253-254
> It doesn't look done to me...

I am a little puzzled about what is to be done here . the TODO states that operations are currently not wrapped . how do you want me to continue ?

> martinvonz wrote in uncommit.py:241
> Do we need to create the temporary commit? I found it hard to reason about (the temporary commit contains the changes that should be removed, which confused me) and we should ideally not leave that commit in the repo. I tried to rewrite it to not write the temporary commit. You can see my patch at http://paste.debian.net/1073278/. As you can see in the changed test case there, it doesn't work with added files. I don't know if that's because of the crecord bug that you mention on line 254 of this version or something else. Hopefully the patch is still a good start and maybe you can fix that bug. It would be great if you can even fix it in crecord (if that's where it is), so all users of crecord can benefit.

do you want me to remove the temporary commit part in this patch or a follow up of this because that will require fixing it up for added files.

  rHG Mercurial


To: taapas1128, #hg-reviewers
Cc: ryanmce, spectral, pulkit, martinvonz, mercurial-devel

More information about the Mercurial-devel mailing list