D6058: patch: include flag-only file changes in "special" while filtering patch (issue5864)

khanchi97 (Sushil khanchi) phabricator at mercurial-scm.org
Sat Mar 16 10:45:04 EDT 2019


khanchi97 marked an inline comment as done.
khanchi97 added inline comments.

INLINE COMMENTS

> mharbison72 wrote in test-split.t:744
> This happens because you can't have nested `#if`.  i.e. this doesn't work:
> 
>   #if ..
>   ...
>   #if ..
>   ...
>   #endif
>   #endif
> 
> You can list multiple requirements on a line, and it is effectively `&&` IIRC.
> 
> I don't see any obvious differences in the output though, other that the bundle saving in the `obsstore-off` case.  I think what you can do here is conditionalize just that line by appending ` (obsstore-off !)` to it the way you would a `(!)`, `(glob)`, or whatever.  That means it must be there for `obsstore-off`.  Conditionalizing the output also makes it easier to see the differences between the difference cases in general.

Thanks, I have updated the patch. I though it is required to a test in this file to run with both the cases `(obsstore-[on|off])`. I have also removed rev no. from graph log as output differed because of stripping.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6058

To: khanchi97, #hg-reviewers, mharbison72
Cc: mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list