D6163: copies: extract function for deciding whether to use changeset-centric algos

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Wed Mar 20 15:17:21 EDT 2019

martinvonz added inline comments.


> pulkit wrote in copies.py:163
> maybe we need to have https://phab.mercurial-scm.org/D2010, but we can drop `algo` (and maybe `use` also) from the name I guess.

I initially didn't have `use` and found it less clear. I also think "use changeset-centric" sounds weird. Maybe just `changesetcentric` as you said then, but that also seems unclear. It feels like we're working around https://phab.mercurial-scm.org/D2010. I can accept that we don't want to queue that, but I don't really like any of the shorter names either. Maybe the current name is fine given the docstring?

  rHG Mercurial


To: martinvonz, #hg-reviewers
Cc: pulkit, mercurial-devel

More information about the Mercurial-devel mailing list