D6122: tests: add a file listing all the flaky tests
av6 (Anton Shestakov)
phabricator at mercurial-scm.org
Thu Mar 21 08:31:17 EDT 2019
av6 added a comment.
In https://phab.mercurial-scm.org/D6122#89818, @lothiraldan wrote:
> @av6 is a `--no-flaky-tests` flag what you had in mind?
Something like that, yes. I suggested that flag seeing how this change introduces a quite specific file with just one line. And I thought "if it's important, let's integrate it deeper into the test runner".
But a flag for run-tests.py is not the only alternative. Now that I think about `#require`, can test-remotefilelog-bgprefetch.t be marked with `#require not-an-exotic-fs-inside-docker` (or whatever the actual thing that causes flakiness if it's known)? hghave.py already checks various filesystem features, why not make it check for the cause of issue6083?
To: lothiraldan, #hg-reviewers
Cc: av6, mercurial-devel
More information about the Mercurial-devel