D6164: wix: add a hook for a prebuild script to inject extra libraries

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Sat Mar 23 11:04:20 EDT 2019


indygreg added a comment.


  I like the flexibility. But I'm not super keen about the interface here. Using a script to inject custom options seems like it could be useful. But as it is currently implemented, the script simply prints out `\0` delimited package names. So one UI wart is `--extra-prebuild-script` being a somewhat generic name but that script only emits package names. `--extra-packages-script` would be a better name.
  
  What do you think about defining an `--extra-package` CLI argument that takes `nargs=*` or an `--extra-packages` that takes a comma-delimited list and then thread that through to the existing `extra_packages` keyword argument? That seems a bit simpler and easier to extend than scripts.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6164

To: durin42, indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list