D6156: branchcache: add attributes to track which nodes are verified

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Sat Mar 23 21:26:50 EDT 2019


yuja added a comment.


  > @@ -231,8 +235,10 @@
  > 
  >       raise ValueError(
  >           r'node %s does not exist' % pycompat.sysstr(hex(node)))
  >   self._entries.setdefault(label, []).append(node)
  > 
  > +            self._verifiedbranches.add(label)
  
  Can we expect that we'll rewrite this `load()` logic to handle verification
  state of multiple nodes (i.e. heads) correctly? It's unclear to me how lazy
  verification will be implemented.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6156

To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list