D6164: wix: add a hook for a prebuild script to inject extra libraries
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Mon Mar 25 12:09:27 EDT 2019
durin42 added a comment.
In https://phab.mercurial-scm.org/D6164#89881, @indygreg wrote:
> I like the flexibility. But I'm not super keen about the interface here. Using a script to inject custom options seems like it could be useful. But as it is currently implemented, the script simply prints out `\0` delimited package names. So one UI wart is `--extra-prebuild-script` being a somewhat generic name but that script only emits package names. `--extra-packages-script` would be a better name.
The script also has to install packages into the virtualenv so they're findable.
> What do you think about defining an `--extra-package` CLI argument that takes `nargs=*` or an `--extra-packages` that takes a comma-delimited list and then thread that through to the existing `extra_packages` keyword argument? That seems a bit simpler and easier to extend than scripts.
I'm open to having both an --extra-package *and* a script argument, if that's what you're proposing. Does that sound workable?
To: durin42, indygreg, #hg-reviewers
More information about the Mercurial-devel