D6174: shelve: let cmdutil.revert() take care of backing up untracked files
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Fri Mar 29 18:39:23 UTC 2019
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
cmdutil.revert() backs up untracked files, so I don't see a reason to
do it shelve.mergefiles(). We have tests for this and they still pass.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6174
AFFECTED FILES
hgext/shelve.py
CHANGE DETAILS
diff --git a/hgext/shelve.py b/hgext/shelve.py
--- a/hgext/shelve.py
+++ b/hgext/shelve.py
@@ -674,18 +674,8 @@
dirstate."""
with ui.configoverride({('ui', 'quiet'): True}):
hg.update(repo, wctx.node())
- files = []
- files.extend(shelvectx.files())
- files.extend(shelvectx.p1().files())
-
- # revert will overwrite unknown files, so move them out of the way
- for file in repo.status(unknown=True).unknown:
- if file in files:
- util.rename(repo.wjoin(file),
- scmutil.backuppath(ui, repo, file))
ui.pushbuffer(True)
- cmdutil.revert(ui, repo, shelvectx, repo.dirstate.parents(),
- **{r'no_backup': True})
+ cmdutil.revert(ui, repo, shelvectx, repo.dirstate.parents())
ui.popbuffer()
def restorebranch(ui, repo, branchtorestore):
To: martinvonz, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list