[PATCH V4] repoview: introduce a `experimental.extra-filter-revs` config

Martin von Zweigbergk martinvonz at google.com
Thu May 2 19:11:40 EDT 2019


Queued.

On Tue, Apr 23, 2019 at 11:34 PM Pierre-Yves David <
pierre-yves.david at ens-lyon.org> wrote:

> Gentle ping on that patch. All the feedback from the previous round
> should have been applied.
>
> On 4/17/19 4:37 PM, Pierre-Yves David wrote:
> > diff --git a/mercurial/configitems.py b/mercurial/configitems.py
> > --- a/mercurial/configitems.py
> > +++ b/mercurial/configitems.py
> > @@ -529,6 +529,13 @@ coreconfigitem('experimental', 'evolutio
> >   coreconfigitem('experimental', 'evolution.track-operation',
> >       default=True,
> >   )
> > +# repo-level config to exclude a revset visibility
> > +#
> > +# The target use case is to use `share` to expose different subset of
> the same
> > +# repository, especially server side. See also `server.view`.
> > +coreconfigitem('experimental', 'extra-filter-revs',
>

I think it would be good to clarify in the name if these revisions are
added or removed from the view, but this is okay as long as it's
experimental.


> > diff --git a/mercurial/repoview.py b/mercurial/repoview.py
> > --- a/mercurial/repoview.py
> > +++ b/mercurial/repoview.py
> > @@ -154,6 +158,35 @@ filtertable = {'visible': computehidden,
> > +    combine = lambda fname: fname + '%' + fid
>

nit: "combine" is very generic. Something like "filename = lambda prefix:
..." might be clearer.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20190502/4a0276b0/attachment.html>


More information about the Mercurial-devel mailing list