D6339: repair: reword comments that I noticed while working on source formatting
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Sat May 4 14:37:19 UTC 2019
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I think this is clearer, and one will also keep us from upsetting
check-code when other formatting cleanups happen.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6339
AFFECTED FILES
mercurial/repair.py
CHANGE DETAILS
diff --git a/mercurial/repair.py b/mercurial/repair.py
--- a/mercurial/repair.py
+++ b/mercurial/repair.py
@@ -364,8 +364,9 @@
striptrees(repo, tr, striprev, files)
def striptrees(repo, tr, striprev, files):
- if 'treemanifest' in repo.requirements: # safe but unnecessary
- # otherwise
+ if 'treemanifest' in repo.requirements:
+ # This logic is safe if treemanifest isn't enabled, but also
+ # pointless, so we skip it if treemanifest isn't enabled.
for unencoded, encoded, size in repo.store.datafiles():
if (unencoded.startswith('meta/') and
unencoded.endswith('00manifest.i')):
@@ -416,7 +417,10 @@
progress.complete()
- if 'treemanifest' in repo.requirements: # safe but unnecessary otherwise
+ if 'treemanifest' in repo.requirements:
+ # otherwise This logic is safe if treemanifest isn't in
+ # use, but it's also not required so we skip it if it's
+ # not needed.
for dir in util.dirs(seenfiles):
i = 'meta/%s/00manifest.i' % dir
d = 'meta/%s/00manifest.d' % dir
To: durin42, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list