D6326: gendoc: group commands by category in man page and HTML help

Sietse (Sietse Brouwer) phabricator at mercurial-scm.org
Sat May 4 11:29:35 EDT 2019


Sietse marked 2 inline comments as done.
Sietse added inline comments.

INLINE COMMENTS

> martinvonz wrote in gendoc.py:188
> Interesting examples.
> 
> I found the `commithook()` quite confusing. I've sent https://phab.mercurial-scm.org/D6336 to remove the arguments from it.
> 
> As you said, the `def one`argument is overridden in one place, so I don't think that's a good comparison.
> 
> The `def doit` actually uses the `remote=remote` as a trick for creating the variable in local scope.
> 
> Even if there are a few more valid cases, the vast majority seems to be just accessing the variables from the closure.

Fair enough. I've removed the outer-scope variables from the function's signature, so now the function closes over them instead.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6326

To: Sietse, #hg-reviewers, martinvonz
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list