D6347: phabricator: add custom vcr matcher to match request bodies
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Fri May 10 11:30:59 EDT 2019
martinvonz added inline comments.
INLINE COMMENTS
> phabricator.py:135-144
> + if len(r1params) is not len(r2params):
> + return False
> + for r1param in r1params:
> + if r1param in r2params:
> + r2params.remove(r1param)
> + else:
> + return False
Can this be written simply `return set(r1params) == set(r2params)`?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6347
To: Kwan, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list