D6348: rust-dirstate: add rust implementation of `parse_dirstate` and `pack_dirstate`

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Mon May 13 05:48:05 EDT 2019


Alphare added a comment.


  Thanks for review. I think I've addressed all of your points.

INLINE COMMENTS

> kevincox wrote in dirstate.rs:34
> You check for PARENT_SIZE then index by PERENT_SIZE*2. This will panic if the size is between the two.

Good catch, thanks!

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6348

To: Alphare, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list