D6372: log: remove an unnecessary "and opts.get('rev')" condition
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Tue May 14 16:34:50 UTC 2019
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
As Yuya pointed out, the condition is unnecessary since
revs.isdescending() would be true if --follow without --rev.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6372
AFFECTED FILES
mercurial/logcmdutil.py
CHANGE DETAILS
diff --git a/mercurial/logcmdutil.py b/mercurial/logcmdutil.py
--- a/mercurial/logcmdutil.py
+++ b/mercurial/logcmdutil.py
@@ -743,7 +743,7 @@
return match
expr = _makerevset(repo, match, pats, slowpath, opts)
- if opts.get('graph') and opts.get('rev'):
+ if opts.get('graph'):
# User-specified revs might be unsorted, but don't sort before
# _makerevset because it might depend on the order of revs
if not (revs.isdescending() or revs.istopo()):
To: martinvonz, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list