D6365: context: move contents of committablectx.markcommitted() to workingctx

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Wed May 15 13:55:27 EDT 2019


durin42 added inline comments.

INLINE COMMENTS

> context.py:1228
>          """
> -
> -        with self._repo.dirstate.parentchange():
> -            for f in self.modified() + self.added():
> -                self._repo.dirstate.normal(f)
> -            for f in self.removed():
> -                self._repo.dirstate.drop(f)
> -            self._repo.dirstate.setparents(node)
> -
> -        # write changes out explicitly, because nesting wlock at
> -        # runtime may prevent 'wlock.release()' in 'repo.commit()'
> -        # from immediately doing so for subsequent changing files
> -        self._repo.dirstate.write(self._repo.currenttransaction())
> +        pass
>  

Nit: this pass isn't needed. I'll fix in flight.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6365

To: martinvonz, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list