D6273: rust-filepatterns: call new Rust implementations from Python
Alphare (Raphaël Gomès)
phabricator at mercurial-scm.org
Thu May 16 04:33:29 EDT 2019
Alphare added a comment.
In https://phab.mercurial-scm.org/D6273#92803, @durin42 wrote:
> Are there any performance implications of this yet?
We (read Octobus) are planning very soon to start benchmarking Rust vs non-Rust Mercurial, so I'll hopefully have an answer within a few weeks.
Though If I had to take a guess, I'd say these patches as well as the few next ones will be detrimental to performance in the short-term. This is because of some limitations in the rust-cpython bindings (some of which are more difficult to fix than others), the inherent overhead of doing ffi, Python idoms awkward for Rust, etc..
The C code I'm re-implemented in some modules is very heavily optimized, but the current approach is to build enough critical mass to have the Rust bits of code interacting as little as possible with Python and then start optimizing/parallelizing.
To: Alphare, #hg-reviewers, durin42
Cc: durin42, mercurial-devel
More information about the Mercurial-devel