D6271: rust-filepatterns: add a Rust implementation of pattern-related utils

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri May 17 01:47:49 EDT 2019

martinvonz added inline comments.


> lib.rs:21
>  };
> +mod filepatterns;
> +

I get the following from `HGWITHRUSTEXT= make local`:

  error[E0583]: file not found for module `filepatterns`
    --> hg-core/src/lib.rs:21:5
  21 | mod filepatterns;
     |     ^^^^^^^^^^^^
     = help: name the file either filepatterns.rs or filepatterns/mod.rs inside the directory "hg-core/src"
  error: aborting due to previous error
  For more information about this error, try `rustc --explain E0583`.
  error: Could not compile `hg-core`.

Also, the command modifies the `rust/Cargo.lock`, which is really annoying. Is there a way to fix that? Or does it only happen when the build fails, so it's not really a problem?

  rHG Mercurial


To: Alphare, #hg-reviewers, kevincox, durin42
Cc: martinvonz, durin42, kevincox, mercurial-devel

More information about the Mercurial-devel mailing list