D6271: rust-filepatterns: add a Rust implementation of pattern-related utils

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Fri May 17 04:54:59 EDT 2019


Alphare added inline comments.

INLINE COMMENTS

> martinvonz wrote in lib.rs:21
> I get the following from `HGWITHRUSTEXT= make local`:
> 
>   error[E0583]: file not found for module `filepatterns`
>     --> hg-core/src/lib.rs:21:5
>      |
>   21 | mod filepatterns;
>      |     ^^^^^^^^^^^^
>      |
>      = help: name the file either filepatterns.rs or filepatterns/mod.rs inside the directory "hg-core/src"
>   
>   error: aborting due to previous error
>   
>   For more information about this error, try `rustc --explain E0583`.
>   error: Could not compile `hg-core`.
> 
> Also, the command modifies the `rust/Cargo.lock`, which is really annoying. Is there a way to fix that? Or does it only happen when the build fails, so it's not really a problem?

It looks like the `filepatterns.rs` file was dropped. Maybe during a `histedit` or other command, but it was definitely there when I sent my patch, and I can't reproduce this issue locally, the file exists. Do you know what happened?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6271

To: Alphare, #hg-reviewers, kevincox, durin42
Cc: martinvonz, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list