[PATCH 1 of 3] extensions: drop support for extsetup() without `ui` argument (API)

Matt Harbison mharbison72 at gmail.com
Sat May 18 20:53:30 EDT 2019


# HG changeset patch
# User Matt Harbison <matt_harbison at yahoo.com>
# Date 1558222428 14400
#      Sat May 18 19:33:48 2019 -0400
# Node ID 38b7b45627a21fa8f9de20d4f173510cf614859f
# Parent  bcb1a2b6cd00e6d47bd0c22e5bbeaaa7f3ea3453
extensions: drop support for extsetup() without `ui` argument (API)

diff --git a/mercurial/extensions.py b/mercurial/extensions.py
--- a/mercurial/extensions.py
+++ b/mercurial/extensions.py
@@ -221,14 +221,7 @@ def _runextsetup(name, ui):
     extsetup = getattr(_extensions[name], 'extsetup', None)
     if extsetup:
         try:
-            try:
-                extsetup(ui)
-            except TypeError:
-                if pycompat.getargspec(extsetup).args:
-                    raise
-                ui.deprecwarn("extsetup for '%s' must take a ui argument"
-                              % name, "4.9")
-                extsetup() # old extsetup with no ui argument
+            extsetup(ui)
         except Exception as inst:
             ui.traceback(force=True)
             msg = stringutil.forcebytestr(inst)


More information about the Mercurial-devel mailing list