D2647: setdiscovery: make progress on most connected groups each roundtrip

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Tue May 21 20:17:43 UTC 2019


marmoute added a comment.


  I feel like I am missing something. Your commit message seems to be talking using at least as many item in the sameple than there is independant connected set. However your code seems to use "heads(undecided)" that is a quite different. Using independant connected set seems like a good trade off (but might be expensive to compute). Using all heads can significantly bloat the discovery without giving it a significant edge in many cases.
  
  Can you clarify this ?

INLINE COMMENTS

> setdiscovery.py:113
>  
> -    def __init__(self, repo, targetheads):
> +    def __init__(self, repo, targetheads, limitedarguments):
>          self._repo = repo

Calling this "limited argument" seems like wireprotocol details leaking into more abstract discovery logic. Can we give it a different name ? (maybe something like "maxsize=200" or "extensiblesample=False") ?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2647

To: martinvonz, #hg-reviewers, indygreg, marmoute
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list