D6422: copies: avoid calling matcher if matcher.always()

Wed May 22 15:17:00 EDT 2019

martinvonz added a comment.

  In https://phab.mercurial-scm.org/D6422#93466, @marmoute wrote:

  > Can you indicate a summary of the total speedup of the series ? (from base to last changesets?).

  Sure, done.

  > Also I am not sure for which case these number apply ? Is this the compatibility mode or after repository conversion ?

  After repo conversion.

  > Can we have number for both ?

  The compatibility number is going to be similar to before this series, since it won't benefit from having the removed set of files available cheaply. It would make sense with a follow-up for speeding up compatibility mode by not filtering out removed files. I'm not sure if that should be a separate option or not.

  > To have a more diverse picture of the performacne of thes change, can you provide timing data for the following case?
  > 
  >   mozilla-central: hg perfpathcopies 76caed42cf7cb7098aa0eb58242dd36054d06865 1daa622bbe42f8a85e0b4880c5c25df8ea60e95f
  >   pypy:            hg perfpathcopies 3c8ac35c653afe108127ca75688e2f8278192512 d7746d32bf9d785bbc0c6afc9aa6015410a38c8f
  >   mercurial:       hg perfpathcopies 7adb1274a4f930e13b35545ef23914ccae7d5534 0c6c600c03fddabcc45f1046e869f84b276fb467
  >   netbeans:        hg perfpathcopies 588c2d1ced709885eb0bc6b88137efbadbb35b76 1aad62e59ddde2ce37882af12fbb202d3b7961dc

  Can you provide some tags you're curious about instead so it's easier to run the same command in both repos (the hashes are different)? I have the mozilla-unified repo and the hg repo converted.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6422

To: martinvonz, #hg-reviewers
Cc: marmoute, mercurial-devel