D6424: rust-discovery: takefullsample() core implementation

kevincox (Kevin Cox) phabricator at mercurial-scm.org
Thu May 23 10:53:51 EDT 2019


kevincox accepted this revision.
kevincox added inline comments.

INLINE COMMENTS

> discovery.rs:124
> +    fn next(&mut self) -> Option<Revision> {
> +        if self.cur > 1 {
> +            return None;

I think it would be nice to remove the magic number.

  if self.cur >= self.parents.len()

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6424

To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list