D6435: narrow: factor out logic to build ellipses related b2parts in separate fn

[martinvonz (Martin von Zweigbergk)]

martinvonz added inline comments.

INLINE COMMENTS

> narrowbundle2.py:69
> +def generateellipsesbundle2(bundler, repo, oldinclude, oldexclude, newinclude,
> +                            newexclude, version, common, known, depth, heads):
> +    newmatch = narrowspec.match(repo.root, include=newinclude,

nit: `common` and `heads` are a closely related, so I'd put `heads` right after `common` here

> narrowbundle2.py:79
>      common = set(common or [nullid])
> -    oldinclude = sorted(filter(bool, kwargs.get(r'oldincludepats', [])))
> -    oldexclude = sorted(filter(bool, kwargs.get(r'oldexcludepats', [])))
> -    known = {bin(n) for n in kwargs.get(r'known', [])}
> -    if known and (oldinclude != include or oldexclude != exclude):
> +    known = {bin(n) for n in known}
> +    if known and (oldinclude != newinclude or oldexclude != newexclude):

nit: we generally work with binary nodeids, so I'd expect this new function to get the nodeids in binary form already

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6435

To: pulkit, durin42, martinvonz, #hg-reviewers
Cc: mercurial-devel