D6389: rust-dirstate: create dirstate submodule

kevincox (Kevin Cox) phabricator at mercurial-scm.org
Fri May 24 05:07:14 EDT 2019


kevincox added inline comments.

INLINE COMMENTS

> Alphare wrote in mod.rs:7
> This is public so that `hg-cpython` can use it. I think it helps with readability too, a "bag of bytes" is sometimes not really helpful when stumbling on code.

I guess the point I am trying to make is why do we pass around this "half-parsed" object. Why can't the public API go straight from bytes -> fully parsed.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6389

To: Alphare, #hg-reviewers
Cc: durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list