D6432: match: de-flake test-doctest.py by not depending on util.dirs() order
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Fri May 24 08:28:52 EDT 2019
yuja added a comment.
> > > @@ -1384,26 +1384,26 @@
> > >
> > > >>> _rootsdirsandparents(
> > > ... [(b'glob', b'g/h/*', b''), (b'glob', b'g/h', b''),
> > > ... (b'glob', b'g*', b'')])
> > >
> > > - (['g/h', 'g/h', ''], [], ['', 'g']) + (['g/h', 'g/h', ''], [], set(['', 'g']))
> >
> > Perhaps, this would break py3 doctests. The repr syntax changed.
>
>
> Good point. However, it turns out they were already broken (b'' prefixes), so I'll leave it for the py3 folks to clean up.
FYI, there's a weird hack to normalize '', u'', and b'' because that's the
only way to make doctests portable.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6432
To: martinvonz, #hg-reviewers
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list