D6442: help: include subtopic in error message if passed

av6 (Anton Shestakov) phabricator at mercurial-scm.org
Fri May 24 09:06:59 EDT 2019


av6 added inline comments.

INLINE COMMENTS

> help.py:826
> +                if subtopic:
> +                    hint += _(" or 'hg help --keyword %s'") % subtopic
>                  raise error.Abort(msg, hint=hint)

Concatenating things is not the best option when it comes to i18n, but even if it were, I think it would make sense to only show here the subtopic, if it's provided. If people are curious about internals.foobar (or config.foobar), then `hg help -k foobar` helps way more than `hg help -k internals`. And we already make sure that the topic that comes before the dot exists, right?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6442

To: ngoldbaum, #hg-reviewers
Cc: av6, mercurial-devel


More information about the Mercurial-devel mailing list