D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri May 31 13:01:28 EDT 2019


martinvonz added inline comments.

INLINE COMMENTS

> durin42 wrote in fix.py:106
> Hm. Is {root} in the templater for the command? Maybe have a sample in the test demonstrating that?
> 
> I'm still dubious that cwd is the right thing, simply because it's unpredictable. I could see $(dirname filepath) or repo root as consistent, but cwd feels off to me somehow. I don't feel strongly though, so as long as {root} exists I can get what I need for hg's fixer definitions...

FWIW, I agree that running using cwd-relative path feels wrong.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6440

To: hooper, #hg-reviewers
Cc: martinvonz, durin42, mercurial-devel


More information about the Mercurial-devel mailing list