D7218: fsmonitor: use stringutil.forcebytestr() instead of str() on an exception

Kwan (Ian Moody) phabricator at mercurial-scm.org
Mon Nov 4 16:53:43 EST 2019


Closed by commit rHG90fba2248693: fsmonitor: use stringutil.forcebytestr() instead of str() on an exception (authored by Kwan).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs Review".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7218?vs=17533&id=17537

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7218/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7218

AFFECTED FILES
  hgext/fsmonitor/__init__.py

CHANGE DETAILS

diff --git a/hgext/fsmonitor/__init__.py b/hgext/fsmonitor/__init__.py
--- a/hgext/fsmonitor/__init__.py
+++ b/hgext/fsmonitor/__init__.py
@@ -193,7 +193,7 @@
             pycompat.bytestr(v["version"]),
         )
     except watchmanclient.Unavailable as e:
-        err = str(e)
+        err = stringutil.forcebytestr(e)
     fm.condwrite(
         err,
         b"fsmonitor-watchman-error",



To: Kwan, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list