D7233: hghave: disallow symlinks on Windows

[mharbison72 (Matt Harbison)]

mharbison72 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Symlinks on Windows require either a special priviledge, or enabling Developer
  Mode.  It's probably the latter that is enabled on the new CI machine.  But
  since Mercurial itself is saying no to symlinks on Windows, the tests for
  symlinks shouldn't be attempted.  This should fix a lot of the noise in the py3
  tests.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7233

AFFECTED FILES
  tests/hghave.py

CHANGE DETAILS

diff --git a/tests/hghave.py b/tests/hghave.py
--- a/tests/hghave.py
+++ b/tests/hghave.py
@@ -431,7 +431,8 @@
 
 @check("symlink", "symbolic links")
 def has_symlink():
-    if getattr(os, "symlink", None) is None:
+    # mercurial.windows.checklink() is a hard 'no' at the moment
+    if os.name == 'nt' or getattr(os, "symlink", None) is None:
         return False
     name = tempfile.mktemp(dir='.', prefix=tempprefix)
     try:



To: mharbison72, #hg-reviewers
Cc: mercurial-devel