D7178: [RFC] rust-matchers: add `Matcher` trait and implement `AlwaysMatcher`

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Tue Nov 5 20:21:55 EST 2019


martinvonz added a comment.


  In D7178#106175 <https://phab.mercurial-scm.org/D7178#106175>, @martinvonz wrote:
  
  > From `test-check-commit.t`:
  >
  >   @@ -25,3 +25,10 @@
  >      >     fi
  >      >   done
  >      > fi
  >   +  Revision e4f5ab3faa27 does not comply with rules
  >   +  ------------------------------------------------------
  >   +  6: summary line doesn't start with 'topic: '
  >   +   [RFC] rust-matchers: add `Matcher` trait and implement `AlwaysMatcher`
  >   +  6: summary keyword should be most user-relevant one-word command or topic
  >   +   [RFC] rust-matchers: add `Matcher` trait and implement `AlwaysMatcher`
  >   +
  
  Sorry, I didn't even see the `[RFC]` prefix, which is what the test was complaining about. I thought it didn't like the hyphen. I'll just drop the `[RFC]` in flight then.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7178/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7178

To: Alphare, #hg-reviewers
Cc: martinvonz, spectral, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list