D7248: repoview: avoid wrapping changelog if there's nothing to filter
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Tue Nov 5 22:35:33 EST 2019
This revision is now accepted and ready to land.
indygreg added a comment.
indygreg accepted this revision.
Nice series.
The only thing that I would consider changing is moving the class definition out of a function so it can more easily be monkeypatched. We can always construct a new type using the generic class as a base to facilitate wrapping the changelog. The code in `localrepo.py` for deriving a custom repo type could be used as inspiration.
REPOSITORY
rHG Mercurial
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7248/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7248
To: martinvonz, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list