D7288: archival: suppress some incorrect pytype failures
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Wed Nov 6 23:00:15 UTC 2019
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Again, I suspect some missing coverage in type stubs for the
stdlib. I'll revisit these later.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D7288
AFFECTED FILES
mercurial/archival.py
CHANGE DETAILS
diff --git a/mercurial/archival.py b/mercurial/archival.py
--- a/mercurial/archival.py
+++ b/mercurial/archival.py
@@ -154,9 +154,11 @@
fname = fname[:-3]
flags = 0
if fname:
- flags = gzip.FNAME
+ flags = gzip.FNAME # pytype: disable=module-attr
self.fileobj.write(pycompat.bytechr(flags))
- gzip.write32u(self.fileobj, int(self.timestamp))
+ gzip.write32u( # pytype: disable=module-attr
+ self.fileobj, int(self.timestamp)
+ )
self.fileobj.write(b'\002')
self.fileobj.write(b'\377')
if fname:
@@ -179,7 +181,7 @@
timestamp=mtime,
)
self.fileobj = gzfileobj
- return tarfile.TarFile.taropen(
+ return tarfile.TarFile.taropen( # pytype: disable=attribute-error
name, pycompat.sysstr(mode), gzfileobj
)
else:
@@ -234,7 +236,7 @@
def addfile(self, name, mode, islink, data):
i = zipfile.ZipInfo(pycompat.fsdecode(name), self.date_time)
- i.compress_type = self.z.compression
+ i.compress_type = self.z.compression # pytype: disable=attribute-error
# unzip will not honor unix file modes unless file creator is
# set to unix (id 3).
i.create_system = 3
To: durin42, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list