D7275: encoding: add comment-based type hints for pytype

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Thu Nov 7 03:14:40 EST 2019


indygreg added inline comments.

INLINE COMMENTS

> encoding.py:24
> +if not globals():  # hide this from non-pytype users
> +    from typing import (
> +        Any,

Am I missing something here? Won't `globals()` always return a dict with elements? And isn't `typing` only available on Python 3?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7275/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7275

To: durin42, #hg-reviewers
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list