D7290: branchmap: pytype is confused about bytestr

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Fri Nov 8 11:46:42 EST 2019


This revision is now accepted and ready to land.
indygreg added a comment.
indygreg accepted this revision.


  Could you please look into this in more detail? Presumably the type checker isn't seeing that `pycompat.bytestr` will accept anything that can be cast to `str`, which `Exception` can. So this feels like it is either a bug in pytype or a missing annotation somewhere. I'd like to know which.
  
  But the comment draws attention to oddness. (I'm assuming we'll be able to disable most type annotator disables long term once more of the code base is properly type annotated.) So I'm fine landing this.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7290/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7290

To: durin42, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list