D7321: revlog: deal with nodemap deletion within the index

[indygreg (Gregory Szorc)]

indygreg added a comment.


  I approve of the direction. In addition to inline comments, same deal as last patch: is there a sentinel entry to worry about?

INLINE COMMENTS

> parsers.py:60
> +        if 'nodemap' in vars(self):
> +            for r in range(start, len(self)):
> +                n = self[r][7]

`pycompat.xrange`.

> revlog.py:223
> +            raise ValueError(b"deleting slices only supports a:-1 with step 1")
> +        for r in pycompat.xrange(i.start, len(self)):
> +            del self.nodemap[self[r][7]]

`pycompat.xrange`.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7321/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7321

To: marmoute, indygreg, #hg-reviewers
Cc: mercurial-devel